refactor: message format and enable cache prompt#21
Merged
Conversation
There was a problem hiding this comment.
Copilot reviewed 4 out of 4 changed files in this pull request and generated 1 comment.
Comments suppressed due to low confidence (1)
cp-agent/cp_agent/utils/message_formats.py:46
- Removing the timestamp field from the Message TypedDict may impact parts of the system (e.g., chat history) that rely on message time information. Consider adding timestamp handling elsewhere if it is expected in production.
- timestamp: str = field(default_factory=lambda: datetime.now().isoformat())
Comment on lines
+79
to
+83
| message_content: list[MessagePart] = [create_text_block(content)] | ||
| if not IS_BEDROCK: | ||
| message_content = [create_text_block(content, "ephemeral")] | ||
| else: | ||
| message_content.append({"cachePoint": {"type": "default"}}) |
There was a problem hiding this comment.
The caching implementation for assistant messages uses an ephemeral cache_control via create_text_block in one branch and appends a separate cachePoint block in the other branch. Consider standardizing the caching representation to avoid potential inconsistencies in message format.
Suggested change
| message_content: list[MessagePart] = [create_text_block(content)] | |
| if not IS_BEDROCK: | |
| message_content = [create_text_block(content, "ephemeral")] | |
| else: | |
| message_content.append({"cachePoint": {"type": "default"}}) | |
| cache_type = "ephemeral" if not IS_BEDROCK else "default" | |
| message_content: list[MessagePart] = [ | |
| create_text_block(content, cache_type), | |
| {"cachePoint": {"type": cache_type}}, | |
| ] |
Owner
Author
There was a problem hiding this comment.
bedrock and other vendors use different formats, sigh
jjleng
force-pushed
the
refactor-message-format
branch
from
58065d5 to
9819865
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.